Horton

Re: [Patch] Improve the test src/test/postmaster/t/003_start_stop.pl

Potapov Alexander <a.potapov@postgrespro.com>

View thread
From: "Potapov Alexander" <a.potapov@postgrespro.com>
To: "Heikki Linnakangas" <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-12-12T07:09:09Z
Lists: pgsql-hackers 
On Wednesday, December 10, 2025 16:28 MSK, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> This seems a little pointless because the test explicitly sets 
> max_connectins and max_wal_senders. It's true that it currently uses 
> more iterations than strictly necessary, but does it matter?

Sure, currently the test works fine. But if we exactly know that the pool size is '2*(MaxConnections + max_wal_senders)' why we do not apply it to the test? The additional benefit is if someone increase the pool size for instance '2*(MaxConnections + max_wal_senders) + some_value' the test fails and indicates an issue.

-- Alexander