Re: pg_validatebackup -> pg_verifybackup?
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-04-10T18:56:48Z
Lists: pgsql-hackers
On 4/10/20 11:37 AM, Tom Lane wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> Over at https://www.postgresql.org/message-id/172c9d9b-1d0a-1b94-1456-376b1e017322@2ndquadrant.com >> Peter Eisentraut suggests that pg_validatebackup should be called >> pg_verifybackup, with corresponding terminology changes throughout the >> code and documentation. > >> Here's a patch for that. I'd like to commit this quickly or abandon in >> quickly, because large renaming patches like this are a pain to >> maintain. I believe that there was a mild consensus in favor of this >> on that thread, so I plan to go forward unless somebody shows up >> pretty quickly to object. > > +1, let's get it done. I'm not sure that Peter suggested verify was the correct name, he just pointed out that verify and validate are not necessarily the same thing (and that we should be consistent in the docs one way or the other). It'd be nice if Peter (now CC'd) commented since he's the one who brought it up. Having said that, I'm +1 on verify. Regards, -- -David david@pgmasters.net
Commits
-
Rename pg_validatebackup to pg_verifybackup some more.
- 7a6b017b3478 13.0 landed
-
Rename pg_validatebackup to pg_verifybackup.
- dbc60c5593f2 13.0 landed