Thread

Commits

  1. Document partitioned_rels in create_modifytable_path header comment.

  1. Missing comment for create_modifytable_path

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-06-15T08:40:37Z

    While working on adding support for tuple routing for foreign 
    partitions, I noticed that in create_modifytable_path, we forgot to add 
    a comment on its new argument 'partitioned_rels'.  Attached a patch for 
    including that in the comments for that function.
    
    Best regards,
    Etsuro Fujita
    
  2. Re: Missing comment for create_modifytable_path

    Robert Haas <robertmhaas@gmail.com> — 2017-06-22T17:53:18Z

    On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
    <fujita.etsuro@lab.ntt.co.jp> wrote:
    > While working on adding support for tuple routing for foreign partitions, I
    > noticed that in create_modifytable_path, we forgot to add a comment on its
    > new argument 'partitioned_rels'.  Attached a patch for including that in the
    > comments for that function.
    
    Committed with a slight adjustment.
    
    -- 
    Robert Haas
    EnterpriseDB: http://www.enterprisedb.com
    The Enterprise PostgreSQL Company
    
    
    
  3. Re: Missing comment for create_modifytable_path

    Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> — 2017-06-23T03:50:52Z

    On 2017/06/23 2:53, Robert Haas wrote:
    > On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
    > <fujita.etsuro@lab.ntt.co.jp> wrote:
    >> While working on adding support for tuple routing for foreign partitions, I
    >> noticed that in create_modifytable_path, we forgot to add a comment on its
    >> new argument 'partitioned_rels'.  Attached a patch for including that in the
    >> comments for that function.
    > 
    > Committed with a slight adjustment.
    
    Thank you for committing this patch (and another one)!
    
    Best regards,
    Etsuro Fujita