Re: Compiler warnings

Joe Conway <mail@joeconway.com>

From: Joe Conway <mail@joeconway.com>

To: Robert Haas <robertmhaas@gmail.com>, Stephen Frost <sfrost@snowman.net>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2016-12-29T15:47:28Z

Lists: pgsql-hackers

On 12/06/2016 01:59 PM, Robert Haas wrote:
> On Tue, Dec 6, 2016 at 3:46 PM, Stephen Frost <sfrost@snowman.net> wrote:
>> Good thought, thanks!
>>
>> Updated patch attached with that change and I also added an Assert() to
>> GetCachedPlan(), in case that code gets whacked around later and somehow
>> we end up falling through without actually setting *plan.
>>
>> Thoughts?
> 
> wfm
> 

Shouldn't this be back-patched? The plancache warning goes back through
9.2 (at least) and the lwlocks warning through 9.5 (or maybe it was 9.4).

Joe

-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Commits

Silence compiler warnings
- cbc62b229520 9.5.6 landed
- 5099e8ee2364 9.6.2 landed
- 6b4a1764aa5d 9.3.16 landed
- 8cb9d0182982 9.4.11 landed
- 35d4dd82c2e8 9.5.6 landed
- 7911e78f6cc5 9.6.2 landed
- d97b14ddab20 10.0 landed
ilence compiler warnings
- fce04516ec5e 9.2.20 landed
Silence Bison deprecation warnings
- 3f9479603cac 9.3.16 landed
- b12b1743b48a 9.2.20 landed
- 55fb759ab3e7 9.4.0 cited
Suppress clang's unhelpful gripes about -pthread switch being unused.
- 73b416b2e412 9.5.0 cited