Re: PATCH: Configurable file mode mask

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Adam Brightwell <adam.brightwell@crunchydata.com>, Robert Haas <robertmhaas@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-05T22:25:46Z
Lists: pgsql-hackers
Hi Tom,

On 3/5/18 5:11 PM, Tom Lane wrote:
> David Steele <david@pgmasters.net> writes:
>> On 2/28/18 2:28 AM, Michael Paquier wrote:
>>> That's basically a recursive chmod, so chmod_recursive is more adapted?
>>> I could imagine that this is useful as well for removing group
>>> permissions, so the new mode could be specified as an argument.
> 
>> The required package (File::chmod::Recursive) for chmod_recursive is not
>> in use anywhere else and was not installed when I installed build
>> dependencies.
> 
>> I'm not sure what the protocol for introducing a new Perl module is?  I
>> couldn't find packages for the major OSes.  Are we OK with using CPAN?
> 
> I don't think that's cool.  Anything that's not part of a standard Perl
> installation is a bit of a lift already, and if it's not packaged by
> major distros then it's really a problem for many people.  (Yeah, they
> may know what CPAN is, but they might have local policy issues about
> installing directly from there.)

This is my view as well.  I don't think CPAN should ever be on a
production box, mostly because of all the other tools that need to be
installed to make it work.

It's a little different here, because these packages are only used for
testing/development.

Of course, maybe I have this wrong and Michael will point out my error.
If not, I'm happy to rework the function (about 15 lines) to be more
generic.

-- 
-David
david@pgmasters.net


Commits

  1. Allow group access on PGDATA

  2. Refactor dir/file permissions

  3. Revert "Add basic TAP test setup for pg_upgrade"

  4. Add basic TAP test setup for pg_upgrade