Horton

Re: Why is subscription/t/031_column_list.pl failing so much?

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-02-06T03:00:00Z
Lists: pgsql-hackers

Attachments

Hello Amit,

05.02.2024 15:20, Amit Kapila wrote:
> If this can be reproduced frequently then we can even try to test the
> patch in that thread by Osumi-San [1] (I haven't tested that it
> applies cleanly but shouldn't be difficult to make it work) based on
> the theory that walsender is starting up at an LSN somewhere before
> where the publication is created.
>
> [1] - https://www.postgresql.org/message-id/TYCPR01MB83737A68CD5D554EA82BD7B9EDD39%40TYCPR01MB8373.jpnprd01.prod.outlook.com
>

Yes, with the aforementioned modification of bgwriter.c and when running
20 tests in parallel, I got failures on iterations 20. 3, 21 ..., but with the
updated Osumi-San's patch (which adds wait_for_catchup('sub1') before every
ALTER SUBSCRIPTION sub1 SET PUBLICATION ...) applied, 300 iterations ran
with no failures.

Best regards,
Alexander

Commits

  1. Back-patch test modifications that were done as part of b6df0798a5.

  2. Fix the intermittent buildfarm failures in 031_column_list.

  3. Fix test race between primary XLOG_RUNNING_XACTS and standby logical slot.

  4. Bound waits in 035_standby_logical_decoding.pl.