Horton

Re: Re: Re: [HACKERS] Custom compression methods

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Ildus Kurbangaliev <i.kurbangaliev@gmail.com>, Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Dmitry Dolgov <9erthalion6@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-15T10:07:14Z
Lists: pgsql-hackers 
On 3/7/19 11:50 AM, Alexander Korotkov wrote:
> On Thu, Mar 7, 2019 at 10:43 AM David Steele <david@pgmasters.net 
> <mailto:david@pgmasters.net>> wrote:
> 
>     On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote:
> 
>      > there are another set of patches.
>      > Only rebased to current master.
>      >
>      > Also I will change status on commitfest to 'Needs review'.
> 
>     This patch has seen periodic rebases but no code review that I can see
>     since last January 2018.
> 
>     As Andres noted in [1], I think that we need to decide if this is a
>     feature that we want rather than just continuing to push it from CF
>     to CF.
> 
> 
> Yes.  I took a look at code of this patch.  I think it's in pretty good 
> shape.  But high level review/discussion is required.

OK, but I think this patch can only be pushed one more time, maximum, 
before it should be rejected.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. docs: Update TOAST storage docs for configurable compression.

  2. Further tweaking of pg_dump's handling of default_toast_compression.

  3. Fix interaction of TOAST compression with expression indexes.

  4. Tidy up more loose ends related to configurable TOAST compression.

  5. Short-circuit slice requests that are for more than the object's size.

  6. Mostly-cosmetic adjustments of TOAST-related macros.

  7. Remove useless configure probe for <lz4/lz4.h>.

  8. Error on invalid TOAST compression in CREATE or ALTER TABLE.

  9. docs: Fix omissions related to configurable TOAST compression.

  10. More code cleanup for configurable TOAST compression.

  11. Bring configure support for LZ4 up to snuff.

  12. Make compression.sql regression test independent of default.

  13. Use valid compression method in brin_form_tuple

  14. Fix up pg_dump's handling of per-attribute compression options.

  15. Allow configurable LZ4 TOAST compression.

  16. Fix inconsistencies in the code

  17. Mostly-cosmetic improvements in memory chunk header alignment coding.

  18. Allow numeric to use a more compact, 2-byte header in many cases.