Re: archive modules

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, "Bossart, Nathan" <bossartn@amazon.com>, David Steele <david@pgmasters.net>, Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>
Date: 2022-09-22T11:54:33Z
Lists: pgsql-hackers
On 17.09.22 11:49, Peter Eisentraut wrote:
> On 14.09.22 23:09, Nathan Bossart wrote:
>> On Wed, Sep 14, 2022 at 09:31:04PM +0200, Peter Eisentraut wrote:
>>> Here is a patch that addresses this.
>>
>> My intent was to present archive_command as the built-in archive library,
>> but I can see how this might cause confusion, so this change seems
>> reasonable to me.
> 
> While working on this, I noticed that in master this conflicts with 
> commit 3cabe45a819f8a2a282d9d57e45f259c84e97c3f.  I have posted a 
> message in that thread looking for a resolution.

I have received clarification there, so I went ahead with this patch 
here after some adjustments in master around that other patch.




Commits

  1. Disallow setting archive_library and archive_command at the same time

  2. Restore archive_command documentation

  3. Doc: improve explanation of when custom GUCs appear in pg_settings.

  4. doc: Add note about re-archiving of same WAL files in docs.

  5. In basic_archive tests, insist on wal_level='replica'.

  6. Allow archiving via loadable modules.

  7. Move the code to archive files via the shell to a separate file.