Horton

Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: 2022-11-01T21:00:27Z
Lists: pgsql-hackers 
On 01.11.22 19:01, Andres Freund wrote:
> I don't know how much longer we can rely on headers being
> -Wdeclaration-after-statement clean, my impression is that people don't have a
> lot of patience for C89isms anymore.

> I wonder if we should try to use -isystem for a bunch of external
> dependencies. That way we can keep the more aggressive warnings with a lower
> likelihood of conflicting with stuff outside of our control.

Python has the same issues.  There are a few other Python-embedding 
projects that use -Wdeclaration-after-statement and complain if the 
Python headers violate it.  But it's getting tedious.  -isystem would be 
a better solution.

Commits

  1. perl: Hide warnings inside perl.h when using gcc compatible compiler