Horton
Menu

Re: Typos in the code and README

Alexander Lakhin <exclusion@gmail.com>

View thread
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>, David Rowley <dgrowleyml@gmail.com>
Date: 2025-04-19T11:00:00Z
Lists: pgsql-hackers 
Hello Michael,

19.04.2025 13:04, Michael Paquier wrote:
> Good finds, Alexander, particularly for the set of function and
> variable names used in the comments that do not match with the
> reality.  I've checked all these, and they're good for me.

Thank you for your attention to this!

>> GIN_TUPLE_ -> GIN_TUPLE_H
> This one is interested.  It should be harmless in practice, but it
> could cause conflicts in theory.
> --

I've included it in the collection because of:
#ifndef GIN_TUPLE_
...
#endif                                                   /* GIN_TUPLE_H */

Best regards,
Alexander Lakhin
Neon (https://neon.tech)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional