Horton

Re: Consolidate ItemPointer to Datum conversion functions

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-06T10:11:54Z
Lists: pgsql-hackers 
On 06/02/2023 11:54, Peter Eisentraut wrote:
> Instead of defining the same set of macros several times, define it once
> in an appropriate header file.  In passing, convert to inline functions.

Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and 
PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most 
datatypes, we define the PG_GETARG and PG_RETURN macros in the same 
header file as the the Datum conversion functions.

- Heikki

Commits

  1. Consolidate ItemPointer to Datum conversion functions