Re: v13: Performance regression related to FORTIFY_SOURCE

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Peter Geoghegan <pg@bowt.ie>
Date: 2020-06-06T01:39:28Z
Lists: pgsql-hackers
On Fri, 2020-06-05 at 14:49 -0700, Andres Freund wrote:
> FWIW, with gcc 10 and glibc 2.30 I don't see such a switch. Taking a
> profile shows me:

...

>   4.65 │       → callq        memcpy@plt
>        │       LogicalTapeWrite():
> 
> I.e. normal memcpy is getting called.
> 
> That's with -D_FORTIFY_SOURCE=2

That's good news, although people will be using ubuntu 18.04 for a
while.

Just to confirm, would you mind trying the example programs in the GCC
bug report?

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95556

> With which compiler / libc versions did you encounter this?

gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
gcc-9 (Ubuntu 9.2.1-19ubuntu1~18.04.york0) 9.2.1 20191109
libc-dev-bin/bionic,now 2.27-3ubuntu1 amd64 [installed]

Regards,
	Jeff Davis





Commits

  1. Fix platform-specific performance regression in logtape.c.