Horton

Re: Generating code for query jumbling through gen_node_support.pl

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, "Drouvot, Bertrand" <bdrouvot@amazon.com>
Date: 2023-01-20T10:56:00Z
Lists: pgsql-hackers 
On 20.01.23 05:35, Michael Paquier wrote:
> On Thu, Jan 19, 2023 at 09:42:03AM +0100, Peter Eisentraut wrote:
>> I see that in the 0003 patch, most location fields now have an explicit
>> markup with query_jumble_ignore.  I thought we had previously resolved to
>> consider location fields to be automatically ignored unless explicitly
>> included (like for the Const node).  This appears to invert that?  Am I
>> missing something?
> As a result, I have rebased the patch set to use the two-attribute
> approach: query_jumble_ignore and query_jumble_location.

Structurally, this looks okay to me now.

In your 0001 patch, most of the comment reformattings for location 
fields are no longer needed, so you should undo those.

The 0002 patch looks good.

Those two could be committed with those adjustments, I think.

I'll read the 0003 again more carefully.  I haven't studied the new 0004 
yet.

Commits

  1. Mark more nodes with attribute no_query_jumble

  2. Include values of A_Const nodes in query jumbling

  3. Generate code for query jumbling through gen_node_support.pl

  4. Rework format of comments in headers for nodes

  5. Move queryjumble.c code to src/backend/nodes/

  6. Fix some compiler warnings in aset.c and generation.c

  7. Reformat some node comments