Horton

Re: [PATCH]Feature improvement for MERGE tab completion

bt22kawamotok <bt22kawamotok@oss.nttdata.com>

View thread View on postgr.es
From: bt22kawamotok <bt22kawamotok@oss.nttdata.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-09-14T05:08:07Z
Lists: pgsql-hackers

Attachments

> When I tried to apply this patch, I got the following warning, please 
> fix it.
> Other than that, I think everything is fine.
> 
> $ git apply fix_tab_completion_merge_v4.patch
> fix_tab_completion_merge_v4.patch:38: trailing whitespace.
>         else if (TailMatches("USING", MatchAny, "ON", MatchAny) ||
> fix_tab_completion_merge_v4.patch:39: indent with spaces.
>                  TailMatches("USING", MatchAny, "AS", MatchAny, "ON",
> MatchAny) ||
> fix_tab_completion_merge_v4.patch:40: indent with spaces.
>                  TailMatches("USING", MatchAny, MatchAny, "ON", 
> MatchAny))
> fix_tab_completion_merge_v4.patch:53: trailing whitespace.
>         else if (TailMatches("WHEN", "MATCHED") ||
> warning: 4 lines add whitespace errors.

Thanks for reviewing.

I fixed the problem and make patch v5.
Please check it.

Regards,

Kotaro Kawamoto

Commits

  1. Push lpp variable closer to usage in heapgetpage()

  2. psql: Improve tab-completion for MERGE.