Horton

Re: postgres_fdw hint messages

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-09-16T13:54:53Z
Lists: pgsql-hackers 
On 13.09.22 21:02, Nathan Bossart wrote:
> On Tue, Sep 13, 2022 at 08:32:43AM +0200, Peter Eisentraut wrote:
>> I notice that for column misspellings, the hint is phrased "Perhaps you
>> meant X." whereas here we have "Did you mean X?".  Let's make that uniform.
> 
> Good point.  I attached a new version of the patch that uses the column
> phrasing.  I wasn't sure whether "reference" was the right word to use in
> this context, but I used it for now for consistency with the column hints.
> I think "specify" or "use" would work as well.

I don't think we need a verb there at all.  I committed it without a verb.

Commits

  1. postgres_fdw: Remove useless DO block in test

  2. Adjust assorted hint messages that list all valid options.