Re: Why is subscription/t/031_column_list.pl failing so much?
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
pgsql-hackers@lists.postgresql.org
Date: 2024-02-06T09:00:00Z
Lists: pgsql-hackers
06.02.2024 09:48, Amit Kapila wrote: > cool, is it possible to see whether this patch changes the runtime of > this test in any noticeable way? > Yes, unfortunately it does. I've measured duration of 100 tests runs without the patch (with pristine bgwriter and with NO_TEMP_INSTALL): real 6m46,031s real 6m52,406s real 6m51,014s But with the patched test, I've got: real 9m39,872s real 9m40,044s real 9m38,236s (nearly 2 seconds increase per one test run) Under Valgrind, the original test run takes: Files=1, Tests=36, 334 wallclock secs ( 0.02 usr 0.00 sys + 163.14 cusr 7.98 csys = 171.14 CPU) But the patched one: Files=1, Tests=36, 368 wallclock secs ( 0.02 usr 0.00 sys + 182.16 cusr 8.90 csys = 191.08 CPU) (30 seconds increase) Maybe the more CPU-efficient solution would be disabling bgworker, as was proposed in another discussion of tests instability: https://www.postgresql.org/message-id/ZaTxhjnPygOdosJ4%40ip-10-97-1-34.eu-west-3.compute.internal Though I think that devising a way to control bgwriter may take more time than we can afford given the current 031 failure rate on the buildfarm (17 failures for the last 3 days). Best regards, Alexander
Commits
-
Back-patch test modifications that were done as part of b6df0798a5.
- 22cecaddf7c8 16.3 landed
- b5abeb751419 15.7 landed
-
Fix the intermittent buildfarm failures in 031_column_list.
- b6df0798a5e2 17.0 landed
-
Fix test race between primary XLOG_RUNNING_XACTS and standby logical slot.
- c59a97313ba3 16.3 landed
- 0e162810df76 17.0 landed
-
Bound waits in 035_standby_logical_decoding.pl.
- f024746484b9 16.3 landed
- 4791f87f34bd 17.0 landed