Re: Improve error messages for database object stats manipulation functions during recovery

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Maxim Orlov <orlovmg@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-11-15T17:37:16Z
Lists: pgsql-hackers

On 2024/11/15 20:59, Maxim Orlov wrote:
> +1 for the patch.
> 
> Recently, one of our customer have tried to upgrade the replica, and, obviously, failed. I don't remember the exact error message, but for him it was not so clear that server is in recovery. Explicitly declaring error is the way to go in my view.
> 
> So, I consider this patch useful. Overall, looks good to me.

Thanks for the review!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION




Commits

  1. Improve error message for database object stats manipulation functions.