Re: narwhal and PGDLLIMPORT

Andres Freund <andres@2ndquadrant.com>

From: Andres Freund <andres@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Peter Eisentraut <peter_e@gmx.net>, Craig Ringer <craig@2ndquadrant.com>, Hiroshi Inoue <inoue@tpf.co.jp>, Andrew Dunstan <andrew@dunslane.net>, Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2014-02-12T21:50:46Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

MinGW: Link with shell32.dll instead of shfolder.dll.
- 53566fc0940c 9.5.0 cited
Centralize getopt-related declarations in a new header file pg_getopt.h.
- 60ff2fdd9970 9.4.0 cited
Get rid of use of dlltool in Mingw builds.
- 846e91e0223c 9.4.0 cited
Export a few more symbols required for test_shm_mq module.
- 7d7eee8bb702 9.4.0 cited
Export set_latch_on_sigusr1 symbol for Windows.
- 708c529c7fde 9.4.0 cited
Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the
- 889f03812916 8.1.0 cited

On February 12, 2014 10:35:06 PM CET, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@2ndquadrant.com> writes:
>> On February 12, 2014 10:23:21 PM CET, Peter Eisentraut
><peter_e@gmx.net> wrote:
>>> There are cases where one module needs symbols from another
>directly.
>>> Would that be affected by this?
>
>> I don't think we have real infrastructure for that yet. Neither from
>the POV of loading several .so's, nor from a symbol visibility. Afaics
>we'd need a working definition of PGDLLIMPORT which inverts the
>declspecs. I think Tom just removed the remnants of that.
>
>No, I've not touched the PGDLLIMPORT macros.  I was hoping to, but it
>looks like we're not getting there :-(

Right, that was just the test patch... Then the macros we're using in fmgr.h for the magic macros (even if not strictly needed) should work for Peter's case.

Andres

-- 
Please excuse brevity and formatting - I am writing this on my mobile phone.

Andres Freund	                   http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services