Horton

Re: Autogenerate some wait events code and documentation

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-10T05:52:23Z
Lists: pgsql-hackers 

On 7/10/23 7:20 AM, Michael Paquier wrote:
> On Mon, Jul 10, 2023 at 07:05:30AM +0200, Drouvot, Bertrand wrote:
>> Yeah there is one in generate-wait_event_types.pl. I was wondering
>> to add one in wait_event_names.txt too (as this is the place where
>> no wait events would be added if any).
> 
> Hmm.  Something like that could be done, for instance:
> 
>   #   src/backend/utils/activity/wait_event_types.h
> -#      typedef enum definitions for wait events.
> +#      typedef enum definitions for wait events, generated from the first
> +#      field.

Yeah, it looks a good place for it.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type