Horton

Thread

Commits

  1. Remove unused #include's in src/backend/utils/adt/*

  1. [PATCH] Remove unused #include's in src/backend/utils/adt/*

    Aleksander Alekseev <aleksander@timescale.com> — 2025-06-16T11:08:54Z

    Hi,

clangd indicates that certain #include's are redundant. Removing them
will speed up the build process a bit.

-- 
Best regards,
Aleksander Alekseev

  2. Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-06-16T14:09:28Z

    Aleksander Alekseev <aleksander@timescale.com> writes:
> clangd indicates that certain #include's are redundant. Removing them
> will speed up the build process a bit.

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms.  Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

			regards, tom lane

  3. Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

    Aleksander Alekseev <aleksander@timescale.com> — 2025-06-16T14:20:51Z

    Hi Tom,

> The removals of <math.h> bother me a bit; I believe those used
> to be necessary on some platforms.  Maybe nowadays everybody is
> close enough to POSIX that you can safely extrapolate from what
> clangd says on your own machine, but it's not zero-risk.

Sounds good to me, let's keep <math.h>.

-- 
Best regards,
Aleksander Alekseev

  4. Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

    Peter Eisentraut <peter@eisentraut.org> — 2025-06-30T10:12:12Z

    On 16.06.25 16:20, Aleksander Alekseev wrote:
>> The removals of <math.h> bother me a bit; I believe those used
>> to be necessary on some platforms.  Maybe nowadays everybody is
>> close enough to POSIX that you can safely extrapolate from what
>> clangd says on your own machine, but it's not zero-risk.
> 
> Sounds good to me, let's keep <math.h>.

committed