Horton

Thread

Commits

  1. Variable renaming in dbcommands.c

  1. Variable renaming in dbcommands.c

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-09T07:21:24Z

    In dbcommands.c function createdb(), there are several sets of very 
similar local variable names, such as "downer" and "dbowner", which is 
very confusing and error-prone.  The first set are the DefElem nodes 
from the parser, the second set are the local variables with the values 
extracted from them.  This patch renames the former to "ownerEl" and so 
on, similar to collationcmds.c and typecmds.c, to improve clarity.

  2. Re: Variable renaming in dbcommands.c

    Daniel Gustafsson <daniel@yesql.se> — 2024-08-09T07:43:37Z

    > On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:

> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer" and "dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second set are the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c, to improve clarity.

No objections, patch LGTM.

--
Daniel Gustafsson

  3. Re: Variable renaming in dbcommands.c

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-15T05:14:26Z

    On 09.08.24 09:43, Daniel Gustafsson wrote:
>> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
>> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer" and "dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second set are the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c, to improve clarity.
> 
> No objections, patch LGTM.

committed