Re: abstract Unix-domain sockets

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-25T07:47:09Z
Lists: pgsql-hackers
On 2020-11-24 02:57, Michael Paquier wrote:
> On Fri, Nov 20, 2020 at 04:06:43PM +0100, Peter Eisentraut wrote:
>> I think we are getting a bit sidetracked here with the message wording. The
>> reason I looked at this was that "remove socket file and retry" is never an
>> appropriate action with abstract sockets.  And on further analysis, it is
>> never an appropriate action with any Unix-domain socket (because with file
>> system namespace sockets, you never get an EADDRINUSE, so it's dead code).
>> So my proposal here is to just delete that line from the hint and leave the
>> rest the same.
> 
> Reading again this thread, +1 on that.

committed, thanks

-- 
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/



Commits

  1. Add support for abstract Unix-domain sockets

  2. Make error hint from bind() failure more accurate

  3. Remove obsolete ifdefs