Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()

Joe Conway <mail@joeconway.com>

From: Joe Conway <mail@joeconway.com>

To: Chao Li <li.evan.chao@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>

Date: 2026-02-27T14:58:34Z

Lists: pgsql-hackers

On 2/27/26 01:04, Chao Li wrote:
> What I'm interested in is the broader policy: when reviewing
> patches, if we encounter a foo() declaration, should we consistently
> request a change to foo(void)? If yes, the standard should be
> documented somewhere.

Perhaps here?

https://wiki.postgresql.org/wiki/Committing_checklist

-- 
Joe Conway
PostgreSQL Contributors Team
Amazon Web Services: https://aws.amazon.com

Commits

Enable -Wstrict-prototypes and -Wold-style-definition by default
- 29bf4ee7496c 19 (unreleased) landed
Prevent -Wstrict-prototypes and -Wold-style-definition warnings
- d7ad79e5069b 19 (unreleased) landed
style: define parameterless functions as foo(void).
- 11171fe1fc83 19 (unreleased) landed