Horton

Re: pg_upgrade test for binary compatibility of core data types

Jacob Champion <pchampion@vmware.com>

View thread
From: Jacob Champion <pchampion@vmware.com>
To: "pryzby@telsasoft.com" <pryzby@telsasoft.com>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>
Cc: "peter.eisentraut@enterprisedb.com" <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "buschmann@nidsa.net" <buschmann@nidsa.net>, "andrew@dunslane.net" <andrew@dunslane.net>, "noah@leadboat.com" <noah@leadboat.com>, "tomas.vondra@2ndquadrant.com" <tomas.vondra@2ndquadrant.com>, "bruce@momjian.us" <bruce@momjian.us>, "andres@anarazel.de" <andres@anarazel.de>
Date: 2021-07-16T16:21:07Z
Lists: pgsql-bugs, pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move into separate file all the SQL queries used in pg_upgrade tests

  2. Add table to regression tests for binary-compatibility checks in pg_upgrade

  3. Fix tests of pg_upgrade across different major versions

  4. Multirange datatypes

  5. Work around cross-version-upgrade issues created by commit 9e38c2bb5.

  6. Declare assorted array functions using anycompatible not anyelement.

  7. Remove factorial operators, leaving only the factorial() function.

  8. Create by default sql/ and expected/ for output directory in pg_regress

  9. Add missing include to pg_upgrade/version.c

  10. Improve the check for pg_catalog.line data type in pg_upgrade

  11. Improve the check for pg_catalog.unknown data type in pg_upgrade

  12. Check for tables with sql_identifier during pg_upgrade

  13. pg_upgrade: clarify the database names in error files

  14. In the pg_upgrade test suite, don't write to src/test/regress.

  15. Allow group access on PGDATA

  16. Refactor dir/file permissions

  17. Remove unused functions in regress.c.

  18. Make WAL segment size configurable at initdb time.

  19. Fix bit-rot in pg_upgrade's test.sh, and improve documentation.

On Fri, 2021-04-30 at 13:33 -0500, Justin Pryzby wrote:
> On Sat, Mar 06, 2021 at 03:01:43PM -0500, Tom Lane wrote:
> > v4-0001 mostly teaches test.sh about specific changes that have to be
> > made to historic versions of the regression database to allow them
> > to be reloaded into current servers.  As already discussed, this is
> > really duplicative of knowledge that's been embedded into the buildfarm
> > client over time.  It'd be better if we could refactor that so that
> > the buildfarm shares a common database of these actions with test.sh.
> > And said database ought to be in our git tree, so committers could
> > fix problems without having to get Andrew involved every time.
> > I think this could be represented as a psql script, at least in
> > versions that have psql \if (but that came in in v10, so maybe
> > we're there already).
> 
> I started this.  I don't know if it's compatible with the buildfarm client, but
> I think any issues maybe can be avoided by using "IF EXISTS".

I'm going to try pulling this into a psql script today and see how far
I get.

> > But I'm not sure I believe
> > that query.  It's got hard-wired assumptions about which typtype values
> > need to be covered.  Why is it okay to exclude range and multirange?
> > Are we sure that all composites are okay to exclude?  Likewise, the
> > restriction to pg_catalog and information_schema schemas seems likely to
> > bite us someday.  There are some very random exclusions based on name
> > patterns, which seem unsafe (let's list the specific type OIDs), and
> > again the nearby comments don't match the code.  But the biggest issue
> > is that this can only cover core datatypes, not any contrib stuff.
> 
> I changed to use regtype/OIDs, included range/multirange and stopped including
> only pg_catalog/information_schema.  But didn't yet handle composites.

Per cfbot, this test needs to be taught about the new
pg_brin_bloom_summary and pg_brin_minmax_multi_summary types.

--Jacob