Re: Add --{no-,}bypassrls flags to createuser

On 2022-05-23 16:29, Michael Paquier wrote:
>> +$node->issues_sql_like(
>> +	[ 'createuser', 'regress_role2', '-a', 'regress_user1' ],
>> +	qr/statement: CREATE ROLE regress_role2 NOSUPERUSER NOCREATEDB 
>> NOCREATEROLE INHERIT LOGIN ADMIN regress_user1;/,
>> +	'add a role as a member with admin option of the newly created 
>> role');
>> +$node->issues_sql_like(
>> +	[ 'createuser', 'regress_role3', '-m', 'regress_user1' ],
>> +	qr/statement: CREATE ROLE regress_role3 NOSUPERUSER NOCREATEDB 
>> NOCREATEROLE INHERIT LOGIN ROLE regress_user1;/,
>> +	'add a role as a member of the newly created role');
> 
> May I ask for the addition of tests when one specifies multiple
> switches for --admin and --member?  This would check the code path
> where you build a list of role names.  You could check fancier string
> patterns, while on it, to look after the use of fmtId(), say with
> role names that include whitespaces or such.

Thanks!
I changed to the test that describes multiple "-m".
It seems to be working without any problems, how about it?


-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION