Re: HEAPDEBUGALL is broken
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-04-21T18:11:26Z
Lists: pgsql-hackers
On 2020-04-19 15:37, Tom Lane wrote: > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: >> The HEAPDEBUGALL define has been broken since PG12 due to tableam >> changes. Should we just remove this? It doesn't look very useful. >> It's been around since Postgres95. >> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL >> (which still compiles correctly). Would we want to keep that? > > +1 for removing both. There are a lot of such debug "features" > in the code, and few of them are worth anything IME. removed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove ACLDEBUG #define and associated code.
- 3436c5e28374 13.0 landed
-
Remove useless (and broken) logging logic in memory context functions.
- ee88ef55dbac 13.0 landed
-
Remove HEAPDEBUGALL
- aaf069aa3452 13.0 landed