Re: Check return value of pclose() correctly

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Ankit Kumar Pandey <itsankitkp@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2022-11-15T14:52:54Z
Lists: pgsql-hackers
On 02.11.22 16:26, Ankit Kumar Pandey wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> Hi Peter,
> This is a review of the pclose return value check patch:
> 
> Contents & Purpose:
> Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
> 
> Initial Run:
> The patch applies cleanly to HEAD. The regression tests all pass
> successfully against the new patch.
> 
> Conclusion:
> At some places pclose return value is handled and this patch adds return value check for remaining values.
> Implementation is in sync with existing handling of pclose.

Committed.  Thanks for the review.




Commits

  1. Check return value of pclose() correctly