Horton

Re: select_parallel test failure: gather sometimes losing tuples (maybe during rescans)?

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-05T21:32:12Z
Lists: pgsql-hackers 

On 03/05/2018 09:37 PM, Thomas Munro wrote:
> On Tue, Mar 6, 2018 at 9:17 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> The optimistic approach seems a little bit less likely to slow this
>> down on systems where barriers are expensive, so I committed that one.
>> Thanks for debugging this; I hope this fixes it, but I guess we'll
>> see.
> 
> Thanks.
> 
> For the record, the commit message (written by me) should have
> acknowledged Tomas's help as reviewer and tester.  Sorry about that.
> 

Meh. You've done the hard work of figuring out what's wrong. The commit
message is perfectly fine.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. shm_mq: Fix detach race condition.

  2. shm_mq: Have the receiver set the sender's less frequently.

  3. shm_mq: Reduce spinlock usage.

  4. Report an ERROR if a parallel worker fails to start properly.