Thread

Re: [PATCH] Fix LISTEN startup race with direct advancement

Joel Jacobson <joel@compiler.org> — 2026-05-27T10:43:54Z

On Tue, May 26, 2026, at 17:40, Tom Lane wrote:
> I agree with this fix, but it seems to me that it changes the meaning
> of the ListenerEntry.listening flag in a rather fundamental way.
> I'm tempted to rename that flag to "committed" or something like that.
>
> (Both "listening" and "committed" appear in dozens of places in this
> file that are not references to this flag, so TBH I'd rather use a
> flag name that is not either of those words.  But I can't think of
> a better name.)

How about renaming listening to removeOnAbort and negating its meaning?

> Also, while the proposed test cases are good for showing that there's
> a bug here, I'm disinclined to commit them.  I do not think there is
> value in them proportionate to the cost of two new isolation-test
> instances.

I agree. I should have said that feel free to remove them.

(Would be nice with a way to attach tests that are meant to be thrown away,
but still let cfbot include them in testing.)

/Joel