Re: Remove MSVC scripts from the tree

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Andrew Dunstan <andrew@dunslane.net>, Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-12-07T07:07:42Z
Lists: pgsql-hackers
On 06.12.23 21:52, Andrew Dunstan wrote:
> 
> On 2023-12-06 We 12:24, Peter Eisentraut wrote:
>> On 06.12.23 17:27, Andrew Dunstan wrote:
>>> But the VS2019 compiler implements enough of C99 to pass our meson 
>>> test, unlike VS2017. Maybe the test is too strict. After all, we know 
>>> we can in fact build with the earlier versions.
>>
>> I just realized that the C99 test is actually our own, not provided by 
>> meson.  (See "c99_test" in meson.build.)
>>
>> Can you try disabling a few bits of that to see what makes it pass for 
>> you?  I suspect it's the structfunc() call.
> 
> 
> Yes, if I comment out the call to structfunc() the test passes on VS2017 
> (compiler version 19.15.26726)

This is strange, because we use code like that in the tree.  There must 
be some small detail that trips it up here.

Perhaps try moving the definition of struct named_init_test outside of 
the function, or make it a typedef.



Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl