Re: review: More frame options in window functions
Hitoshi Harada <umi.tanuki@gmail.com>
From: Hitoshi Harada <umi.tanuki@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Erik Rijkers <er@xs4all.nl>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-01-19T20:02:16Z
Lists: pgsql-hackers
Attachments
- more_frame_options.20100120.patch.gz (application/x-gzip) patch
2010/1/19 Hitoshi Harada <umi.tanuki@gmail.com>: > Yeah, that's my point, too. The planner has to distinguish "four" from > sort pathkeys and to teach the executor the simple information which > column should be used to determine frame. I was bit wrong because some > of current executor code isn't like it, like using ordNumCols == 0 to > know whether partition equals to frame, though.... And here's another version to fix this problem (I hope). Now the planner distinguish sort column from actual significant pathkeys. I tested it on both of 32bit and 64bit Linux. Regards, -- Hitoshi Harada