Re: review: More frame options in window functions

Hitoshi Harada <umi.tanuki@gmail.com>

View thread

From: Hitoshi Harada <umi.tanuki@gmail.com>

To: Pavel Stehule <pavel.stehule@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2010-01-14T18:32:32Z

Lists: pgsql-hackers

Attachments

more_frame_options.20100115.patch.gz (application/x-gzip) patch

2010/1/14 Pavel Stehule <pavel.stehule@gmail.com>:
> Hello
>
> I looked on Hitoshi's patch - and my result is:

Thanks for the review. I've found another crash today and attached is
fixed version. The case is:

SELECT four, sum(ten) over (PARTITION BY four ORDER BY four RANGE 1
PRECEDING) FROM tenk1 WHERE unique1 < 10;

The planner recognizes windowagg->ordNumCol as 0 for optimization, but
RANGE offset cases should really have interest on that value as the
syntax says.

Regards,


-- 
Hitoshi Harada