Horton

Re: LLVM strip -x fails

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, Palle Girgensohn <girgen@pingpong.net>, pgsql-hackers@postgresql.org
Date: 2023-04-21T16:41:54Z
Lists: pgsql-hackers 
On 20.04.23 17:33, Andres Freund wrote:
> Peter, it's unlikely given the timeframe, but do you happen to remember why
> you specified -x when stripping static libs? This seems to be all the way back
> from
> 
> commit 563673e15db995b6f531b44be7bb162330ac157a
> Author: Peter Eisentraut<peter_e@gmx.net>
> Date:   2002-04-10 16:45:25 +0000
> 
>      Add make install-strip target.
> 
> 
> Afaict the only safe thing to use when stripping static libs is
> -g/--strip-debug.

I suspect this was copied from GNU Libtool.  Libtool still has that but 
later changed the stripping of static libraries on darwin to "strip -S". 
  Maybe should adopt that.

Commits

  1. Use --strip-unneeded when stripping static libraries with GNU strip.

  2. Add make install-strip target.