Re: Common function for percent placeholder replacement

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-12-19T08:13:44Z
Lists: pgsql-hackers
On 14.12.22 18:05, Justin Pryzby wrote:
> On Wed, Dec 14, 2022 at 08:31:02AM +0100, Peter Eisentraut wrote:
>> +	return replace_percent_placeholders(base_command, "df", (const char *[]){target_detail, filename});
> 
> This is a "compound literal", which I gather is required by C99.
> 
> But I don't think that's currently being exercised, so I wonder if it's
> going to break some BF members.

We already use this, for example in pg_dump.




Commits

  1. Code cleanup

  2. Common function for percent placeholder replacement