Re: Use merge-based matching for MCVs in eqjoinsel

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: David Geier <geidav.pg@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-09-17T09:40:01Z
Lists: pgsql-hackers
Hi David,

In v2 patch, when the join is reversed we pass the commutator operator 
Oid to eqjoinsel_semi(), and inside that function we immediately call 
get_opcode(<commutator operator Oid>). Did you mean for the function to 
take an operator Oid instead of an here?

If that was unintentional, perhaps the cleanest fix is to add a new 
'operator' parameter to eqjoinsel_semi() so we can keep passing 
'opfuncoid' as before and avoid changing the behavior.

-- 
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com