Horton

Re: Allow pg_archivecleanup to remove backup history files

torikoshia <torikoshia@oss.nttdata.com>

View thread View on postgr.es
From: torikoshia <torikoshia@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org
Date: 2023-05-22T09:24:49Z
Lists: pgsql-hackers

Attachments

On 2023-05-15 15:22, Michael Paquier wrote:
> On Mon, May 15, 2023 at 03:16:46PM +0900, torikoshia wrote:
>> On 2023-05-15 09:18, Michael Paquier wrote:
>>> How about plugging in some long options, and use something more
>>> explicit like --clean-backup-history?
>> 
>> Agreed.
> 
> If you begin to implement that, it seems to me that this should be
> shaped with a first separate patch that refactors the code to use
> getopt_long(), and a second patch for the proposed feature that builds
> on top of it.
Thanks for your advice, attached patches.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Commits

  1. pg_archivecleanup: Add --clean-backup-history

  2. pg_archivecleanup: Refactor loop doing old segment removals

  3. Introduce long options in pg_archivecleanup