Re: Virtual generated columns

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: vignesh C <vignesh21@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, jian he <jian.universality@gmail.com>
Date: 2025-02-07T12:36:28Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Expand virtual generated columns for ALTER COLUMN TYPE

  2. Eliminate code duplication in replace_rte_variables callbacks

  3. Expand virtual generated columns in the planner

  4. Virtual generated columns

  5. Additional tests for stored generated columns

  6. Improve generated_stored test

  7. Fix handling of CREATE DOMAIN with GENERATED constraint syntax

  8. Add pg_constraint rows for not-null constraints

  9. Put generated_stored test objects in a schema

  10. Rename regress test generated to generated_stored

  11. Small code simplification

  12. Remove useless code

  13. Remove useless initializations

  14. doc: Clarify that pg_attrdef also stores generation expressions

  15. Clean out column-level pg_init_privs entries when dropping tables.

  16. Re-implement the ereport() macro using __VA_ARGS__.

On 06.02.25 14:03, vignesh C wrote:
> One suggestion: for the option where the user specifies
> publish_generated_columns as virtual (as shown below), could we change
> the error indicating that virtual generated columns are not currently
> supported?
> CREATE PUBLICATION pub1 FOR TABLE t1 WITH (publish_generated_columns = virtual);
> 
> Also, could we add a XXX comment in either decode.c, pgoutput.c, or
> publicationcmds.c outlining what would be needed to support the
> replication of virtual generated columns? Specifically, it would be
> helpful if we could include how to retrieve virtual generated column
> data during decoding. This would serve as a reference for anyone
> working on enabling logical replication of virtual generated columns
> in the future.

I think adding support for virtual generated columns in logical 
replication would require a lot more work than filling in the handful of 
places that we know about.  (Otherwise, we'd already have done it now.) 
So I'd rather not give potentially misleading or incomplete advice.