Horton

Re: Underscores in numeric literals

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>, Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-01-31T15:28:48Z
Lists: pgsql-hackers 
On 23.01.23 21:45, Dean Rasheed wrote:
> On Wed, 4 Jan 2023 at 09:28, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>>
>> In addition, I think that strip_underscores() could then go away if
>> numeric_in() were made to handle underscores.
>>
>> Essentially then, that would move all responsibility for parsing
>> underscores and non-decimal integers to the datatype input functions,
>> or their support routines, rather than having it distributed.
> 
> Here's an update with those changes.

This looks good to me.

Did you have any thoughts about what to do with the float types?  I 
guess we could handle those in a separate patch?

Commits

  1. Allow underscores in integer and numeric constants.