Horton

Re: PostgresNode::append_conf considered dangerous

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgreSQL.org
Date: 2017-04-23T00:56:28Z
Lists: pgsql-hackers 

On 04/22/2017 04:19 PM, Tom Lane wrote:
>
> I think instead we should change append_conf to append a newline, and
> simplify the callers that could thereby be simplified.  I don't see
> any callers that would be broken by that; and we do not have any config
> files in which extra blank lines are problematic.
>
> 			


+1. Not sure how we survived so long with it the way it is.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Make PostgresNode::append_conf append a newline automatically.