Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>, Jesse Zhang <sbjesse@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-02-03T16:44:46Z
Lists: pgsql-hackers 
On 2023-01-22 Su 17:47, Tom Lane wrote:
> Andres Freund<andres@anarazel.de>  writes:
>> I strongly dislike it, I rarely get it right by hand - but it does have some
>> benefit over aligning variable names based on the length of the type names as
>> uncrustify/clang-format: In their approach an added local variable can cause
>> all the other variables to be re-indented (and their initial value possibly
>> wrapped). The fixed alignment doesn't have that issue.
> Yeah.  That's one of my biggest gripes about pgperltidy: if you insert
> another assignment in a series of assignments, it is very likely to
> reformat all the adjacent assignments because it thinks it's cool to
> make all the equal signs line up.  That's just awful.  You can either
> run pgperltidy on new code before committing, and accept that the feature
> patch will touch a lot of lines it's not making real changes to (thereby
> dirtying the "git blame" history) or not do so and thereby commit code
> that's not passing tidiness checks.  Let's *not* adopt any style that
> causes similar things to start happening in our C code.


Modern versions of perltidy give you much more control over this, so 
maybe we need to investigate the possibility of updating. See the latest 
docco at 
<*https://metacpan.org/dist/Perl-Tidy/view/bin/perltidy#Completely-turning-off-vertical-alignment-with-novalign>
*

Probably we'd want to use something like

|--valign-exclusion-list=||'= => ,'|
||
||
|cheers|
||
|andrew|

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.