Re: Removing unneeded self joins

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

From: "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>

To: Andres Freund <andres@anarazel.de>

Cc: Greg Stark <stark@mit.edu>, Ronan Dunklau <ronan.dunklau@aiven.io>, Laurenz Albe <laurenz.albe@cybertec.at>, Hywel Carver <hywel@skillerwhale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Konstantin Knizhnik <knizhnik@garret.ru>

Date: 2022-03-24T05:21:54Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination
- 717d0e8dd945 18.0 landed
Put enable_self_join_elimination into postgresql.conf.sample
- c2d329260cd8 18.0 landed
Get rid of ojrelid local variable in remove_rel_from_query()
- e167191dc146 18.0 landed
Implement Self-Join Elimination
- fc069a3a6319 18.0 cited
Revert: Remove useless self-joins
- d1d286d83c0e 17.0 landed
Replace lateral references to removed rels in subqueries
- 466979ef031a 17.0 landed
Replace relids in lateral subquery parse tree during SJE
- 489072ab7a9e 17.0 landed
Forbid SJE with result relation
- 8c441c082797 17.0 landed
Fix misuse of RelOptInfo.unique_for_rels cache by SJE
- 30b4955a4668 17.0 landed
Replace the relid in some missing fields during SJE
- a7928a57b9f0 17.0 landed
Revert 56-bit relfilenode change and follow-up commits.
- a448e49bcbe4 16.0 cited
Stabilize timetz test across DST transitions.
- 4a071afbd056 14.0 cited
Speed up finding EquivalenceClasses for a given set of rels
- 3373c7155350 13.0 cited
Fix mark-and-restore-skipping test case to not be a self-join.
- 24d08f3c0a1f 12.0 landed

Attachments

v31-0001-Remove-self-joins.patch (text/x-patch) patch v31-0001

On 3/22/22 05:58, Andres Freund wrote:
> Hi,
> 
> On 2022-03-04 15:47:47 +0500, Andrey Lepikhov wrote:
>> Also, in new version of the patch I fixed one stupid bug: checking a
>> self-join candidate expression operator - we can remove only expressions
>> like F(arg1) = G(arg2).
> 
> This CF entry currently fails tests: https://cirrus-ci.com/task/4632127944785920?logs=test_world#L1938
> 
> Looks like you're missing an adjustment of postgresql.conf.sample
> 
> Marked as waiting-on-author.
Thanks, I fixed it.

-- 
regards,
Andrey Lepikhov
Postgres Professional