Outdated replication protocol error?

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: pgsql-hackers@postgresql.org
Cc: Simon Riggs <simon@2ndQuadrant.com>, Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-01-12T00:06:28Z
Lists: pgsql-hackers
Commit 5ee2197767 (about 4 years old) introduced the error:

  "IDENTIFY_SYSTEM has not been run before START_REPLICATION"

But it seems like running START_REPLICATION first works (at least in
the simple case).

We should either:

1. Document that IDENTIFY_SYSTEM must always be run before
START_REPLICATION, and always issue a WARNING if that's not done (an
ERROR might break existing applications); or

2. If the commit is out of date and no longer needed, or if it's easy
enough to fix, just remove the error (and Assert a valid
ThisTimeLineID).

Regards,
	Jeff Davis






Commits

  1. Eliminate replication protocol error related to IDENTIFY_SYSTEM.

  2. Ensure ThisTimeLineID is valid before START_REPLICATION