Re: pgbench - extend initialization phase control

btendouan <btendouan@oss.nttdata.com>

From: btendouan <btendouan@oss.nttdata.com>
To: coelho@cri.ensmp.fr, "ibrar.ahmad@gmail.com:" <pgsql-hackers@lists.postgresql.org>
Date: 2019-10-10T04:30:54Z
Lists: pgsql-hackers
Hello Fabien,

> ---------- Forwarded message ---------
> From: Fabien COELHO <coelho@cri.ensmp.fr>
> Date: Tue, Jul 16, 2019 at 4:58 PM
> Subject: Re: pgbench - extend initialization phase control
> To: Ibrar Ahmed <ibrar.ahmad@gmail.com>
> Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
> 
> 
> 
> Hello Ibrar,
> 
>> The following review has been posted through the commitfest 
>> application:
>> make installcheck-world:  tested, passed
>> Implements feature:       tested, passed
>> Spec compliant:           tested, passed
>> Documentation:            not tested
>> 
>> Other than that, the patch looks good to me.
>> 
>> The new status of this patch is: Ready for Committer
> 
> Thanks for the review.
> 
> Attached v2 is a rebase after ce8f9467.

Thanks for your new patch.

But I failed to apply it. Please rebase it against HEAD.

Regards,

---------
Anna



Commits

  1. Add query cancellation capabilities in pgbench init phase

  2. Add "G" (server-side data generation) as an initialization step in pgbench.