Re: removing tsearch2
Josh Berkus <josh@berkus.org>
From: Josh Berkus <josh@berkus.org>
To: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>,
Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>,
Magnus Hagander <magnus@hagander.net>,
Michael Paquier <michael.paquier@gmail.com>,
Daniel Verite <daniel@manitou-mail.org>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
Fujii Masao <masao.fujii@gmail.com>, Vladimir Rusinov <vrusinov@google.com>,
Jim Nasby <Jim.Nasby@bluetreble.com>,
Cynthia Shang <cynthia.shang@crunchydata.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-02-10T18:14:14Z
Lists: pgsql-hackers
On 02/10/2017 06:41 AM, David Steele wrote: > On 2/10/17 6:28 AM, Robert Haas wrote: >> On Thu, Feb 9, 2017 at 7:37 PM, Andres Freund <andres@anarazel.de> wrote: >>> On 2017-02-09 19:19:21 -0500, Stephen Frost wrote: >>>> * Robert Haas (robertmhaas@gmail.com) wrote: >>>>> On Thu, Feb 9, 2017 at 4:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>>>>> Also, our experience with contrib/tsearch2 suggests that the extension >>>>>> shouldn't be part of contrib, because we have zero track record of getting >>>>>> rid of stuff in contrib, no matter how dead it is. >>>>> >>>>> Let's nuke tsearch2 to remove this adverse precedent, and then add the >>>>> new thing. >>>>> >>>>> Anybody who still wants tsearch2 can go get it from an old version, or >>>>> somebody can maintain a fork on github. >>>> >>>> Works for me. >>> >>> +1 >> >> OK, that's three votes in favor of removing tsearch2 (from core, >> anyone who wants it can maintain a copy elsewhere). Starting a new >> thread to make sure we collect all the relevant votes, but I really, >> really think it's past time for this to go away. The last actual >> change to tsearch2 which wasn't part of a wider cleanup was >> 3ca7eddbb7c4803729d385a0c9535d8a972ee03f in January 2009, so it's been >> 7 years since there's been any real work done on this -- and the >> release where we brought tsearch into core is now EOL, plus three more >> releases besides. > > +1 > +1 -- Josh Berkus Containers & Databases Oh My!
Commits
-
Remove contrib/tsearch2.
- 7ada2d31f47f 10.0 landed
-
Create stub functions to support pg_upgrade of old contrib/tsearch2.
- eb43e851d6b3 9.6.0 cited
-
Add backwards-compatible declarations of some core GIN support functions.
- 6595dd04d136 9.1.0 cited
-
Fix bug with multiple evaluation of tsearch2 compatibility trigger, trigger
- 3ca7eddbb7c4 8.4.0 cited