Horton

Re: convert elog(LOG) calls to ereport

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-12-04T13:34:57Z
Lists: pgsql-hackers 
On 2020-12-03 08:02, Michael Paquier wrote:
> +   else
> +       ereport(LOG,
> +               (errmsg("checkpoint starting:%s%s%s%s%s%s%s%s",
> 
> Would it be better to add a note for translators here, in short that
> all those %s are options related to checkpoint/restartpoints?

done

> The ones in geqo_erx.c look like debugging information, and the ones
> in win32_shmem.c for segment creation are code paths only used by the
> postmaster.

I dialed those back a bit.

Commits

  1. Factor out system call names from error messages

  2. Convert elog(LOG) calls to ereport() where appropriate