Re: Occasional tablespace.sql failures in check-world -jnn

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2021-03-08T10:53:57Z
Lists: pgsql-hackers
On 09.12.20 08:55, Michael Paquier wrote:
>> It's not clear to me why we have this logic in the makefile at all?
>> Somebody taught pg_regress to do so, but only on windows... See
>> convert_sourcefiles_in().
> 
> ...  Because we may still introduce this problem again if some new
> stuff uses src/test/pg_regress in a way similar to pg_upgrade,
> triggering again tablespace-setup.  Something like the attached may be
> enough, though I have not spent much time checking the surroundings,
> Windows included.

This patch looks alright to me.



Commits

  1. Move tablespace path re-creation from the makefiles to pg_regress