Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-01-23T12:11:53Z
Lists: pgsql-hackers 
On 2023-01-22 Su 11:18, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>>> ... btw, can we get away with making the diff run be "diff -upd"
>>> not just "diff -u"?  I find diff output for C files noticeably
>>> more useful with those options, but I'm unsure about their
>>> portability.
>> I think they are available on Linux, MacOS and FBSD, and on Windows (if
>> anyone's actually using it for this) it's likely to be Gnu diff. So I
>> think that's probably enough coverage.
> I checked NetBSD as well, and it has all three too.
>
> Patch looks good to me.
>
> 			


Thanks, pushed.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.