Horton

Re: [BUG] failed assertion in EnsurePortalSnapshotExists()

Drouvot, Bertrand <bdrouvot@amazon.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Ranier Vilela <ranier.vf@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-01T05:27:42Z
Lists: pgsql-hackers 
On 9/30/21 8:25 PM, Tom Lane wrote:
> "Drouvot, Bertrand" <bdrouvot@amazon.com> writes:
>> On 9/30/21 7:16 PM, Tom Lane wrote:
>>> PS: Memo to self: in the back branches, the new field has to be
>>> added at the end of struct Portal.
>> out of curiosity, why?
> Sticking it into the middle would create an ABI break for any
> extension code that's looking at struct Portal, due to movement
> of existing field offsets.  In HEAD that's fine, so we should
> put the field where it makes the most sense.  But we have to
> be careful about changing globally-visible structs in released
> branches.

Got it, thanks!

Bertrand

Commits

  1. Fix Portal snapshot tracking to handle subtransactions properly.