Re: Support to define custom wait events for extensions
Masahiro Ikeda <ikedamsh@oss.nttdata.com>
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com>, Tristan Partin
<tristan@neon.tech>, pgsql-hackers@lists.postgresql.org
Date: 2023-08-15T00:14:15Z
Lists: pgsql-hackers
On 2023-08-14 18:26, Michael Paquier wrote: > On Mon, Aug 14, 2023 at 05:55:42PM +0900, Masahiro Ikeda wrote: >> I'm thinking a name like "contrib name + description summary" would >> be nice. The "contrib name" is namespace-like and the "description >> summary" >> is the same as the name of the waiting event name in core. For >> example, >> "DblinkConnect" for dblink. In the same as the core one, I thought the >> name >> should be the camel case. > > Or you could use something more in line with the other in-core wait > events formatted as camel-case, like DblinkConnect, etc. > >> BTW, is it better to discuss this in a new thread because other >> developers >> might be interested in user-facing wait event names? I also would like >> to >> add documentation on the wait events for each modules, as they are not >> mentioned >> now. > > Saying that, having some documentation on the page of each extension > is mandatory once these can be customized, in my opinion. All that > should be discussed on a new, separate thread, to attract the correct > audience. OK. I'll make a new patch and start a new thread. Regards, -- Masahiro Ikeda NTT DATA CORPORATION
Commits
-
Change custom wait events to use dynamic shared hash tables
- af720b4c50a1 17.0 landed
-
Support custom wait events for wait event type "Extension"
- c9af05465307 17.0 landed
-
Add WAIT_EVENT_{CLASS,ID}_MASK in wait_event.c
- 7395a90db87b 17.0 landed
-
worker_spi: Switch to TAP tests
- 320c311fda91 17.0 cited
-
Simplify some conditions related to [LW]Lock in generate-wait_event_types.pl
- c17164aec88c 17.0 landed