Re: Listen / Notify - what to do when the queue is full

Joachim Wieland <joe@mcknight.de>

From: Joachim Wieland <joe@mcknight.de>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Jeff Davis <pgsql@j-davis.com>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Smith <greg@2ndquadrant.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, "Florian G. Pflug" <fgp@phlo.org>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers@postgresql.org, Arnaud Betremieux <arnaud.betremieux@keyconsulting.fr>

Date: 2010-02-10T23:52:18Z

Lists: pgsql-hackers

Attachments

listennotify.11.diff (text/x-patch) patch

On Mon, Feb 8, 2010 at 5:16 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> These are the on-disk notifications, right?  It seems to me a bit
> wasteful to store channel name always as NAMEDATALEN bytes.  Can we
> truncate it at its strlen?

Attached is a new and hopefully more or less final patch for LISTEN / NOTIFY.

The following items have been addressed in this patch:

 - only store strlen(channel) instead of NAMEDATALEN bytes on disk
 - limit to 7-bit ASCII
 - forbid 2PC and LISTEN/NOTIFY for now
 - documentation changes
 - add missing tab completion for NOTIFY
 - fix pg_notify() behavior with respect to NULLs, too long and too
short parameters
 - rebased to current HEAD, OID conflicts resolved


Joachim